你们做朋友多久了?
for 后面接的是时间,陈述句式：you have been friends for (时间).