这句话的主语是dream,he had had for so many years 是主语的定语,是定语从句作定语.ended 是谓语,there 是地点状语.
had had for so many years 是过去完成时,是主动语态.第一个had 是过去完成时的助动词,
第二个had 是定语从句中的谓语动词.have a dream 是“有梦想；做梦”的意思.
“他拥有了好多年的梦想在那儿终结了.”
希望我的回答能够帮到你,